Definitive Code - Latest Comments

Re: Theming in Rails 2 and Rails 3

Robert Rouse — Thu, 15 Jul 2010 20:37:40 -0000

That would be true if the theme variable were a string. It is not.

ActionView::Base.process_view_paths takes a string and returns a ActionView::PathSet::Path which is then prepended.

Re: Theming in Rails 2 and Rails 3

Ozgun Koyun — Thu, 15 Jul 2010 20:33:19 -0000

Hi,

Using "prepend_view_path" to support multiple themes is a very expensive solution. You can see another solution to this problem here: http://www.axehomeyg.com/2009/...

-ozgun.

Re: dnif – The new search gem for sphinx

Rafael Souza — Tue, 13 Jul 2010 18:37:12 -0000

Greg,

This gem was created to a bit specific case I am working on, I needed add search to an application almost finished, and most data that should be indexed was ruby code (methods) and thinking-sphinx only index database columns.
So I decided create a gem and share it with the world :)

Re: dnif – The new search gem for sphinx

Greg — Tue, 13 Jul 2010 17:41:28 -0000

Why not use thinking_sphinx ?

Re: Theming in Rails 2 and Rails 3

Robert Rouse — Mon, 12 Jul 2010 08:53:36 -0000

I'll adjust to make it simpler. Thank you!

Re: Theming in Rails 2 and Rails 3

Stephen Murdoch — Mon, 12 Jul 2010 02:08:26 -0000

real nice idea - thanks for sharing

Re: Theming in Rails 2 and Rails 3

James — Mon, 12 Jul 2010 01:25:10 -0000

FYI, Rails.root is a Pathname object. That means you can do this: YAML.load(Rails.root.join('config', 'settings.yml').open).

Re: dnif – The new search gem for sphinx

Vojto — Sun, 11 Jul 2010 14:19:26 -0000

Fair answer, and also it's much easier for people to start using it right away like this. I think this is an amazing gem for people who just need to add search to their application.

Re: dnif – The new search gem for sphinx

Robert Rouse — Sun, 11 Jul 2010 13:43:08 -0000

One could move it to a YAML configuration file, but it's a very model specific config. Doing it this way keeps the model specific stuff in the model, which I believe is better in this case for clarity.

Re: dnif – The new search gem for sphinx

Vojto — Sun, 11 Jul 2010 05:58:27 -0000

It looks very cool!

But what's up with this whole "using class methods to define stuff" thing.

I mean this:

define_index do
field :title
field :body

where ["draft = ?", false]
end

It does not belong there, this code. Rails does it this way and everything, but this is configuration. A YAML file or something would make sense.

Yes we are so used to this. But that's not OOP this.